Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): add requestLogger and responseLogger options #2020

Merged

Conversation

danemauland
Copy link
Contributor

add requestLogger and responseLogger options to CreateClientParams to match options listed in documentation and contentful-sdk-core

Closes #434

@danemauland danemauland requested a review from a team as a code owner September 25, 2023 16:44
add requestLogger and responseLogger options to CreateClientParams to match
options listed in documentation and contentful-sdk-core

Closes contentful#434
@marcolink marcolink force-pushed the add-loggers-to-CreateClientParams branch from ccf6c79 to 9bfc7c4 Compare October 11, 2023 10:54
@marcolink
Copy link
Member

@danemauland thanks for your contributions 🎉
We will merge it after all tests passed 👍

@marcolink marcolink enabled auto-merge (squash) October 11, 2023 10:57
@marcolink marcolink merged commit a32576d into contentful:master Oct 11, 2023
2 checks passed
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 10.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typedefs do not include requestLogger, responseLogger
2 participants