feat(sync): preserve subpath in repositories when registry is defined #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechIsCool
force-pushed
the
feat/sync-nested-repos
branch
from
0505df9 to
18f3df3
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
TechIsCool
force-pushed
the
feat/sync-nested-repos
branch
from
18f3df3 to
83fb4f5
Compare
- Add `RegistryName` field to `repoDescriptor` for better registry handling. - Introduce `getSubPath` function to cleanly handle subpath extraction. - Update functions `imagesToCopyFromRegistry` and `filterSourceReferences` to include `RegistryName`. - Modify `syncOptions.run` to use `getSubPath`. - Add unit tests for `getSubPath`. Resolves - containers#1992 Signed-off-by: David Beck <[email protected]>
TechIsCool
force-pushed
the
feat/sync-nested-repos
branch
from
83fb4f5 to
863373e
Compare
mtrmac
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks for the PR.
We can’t just change what existing commands do, and break many existing scripts.
(And, as detailed throughout the GitHub issues, I’m uninterested in adding more mapping features. We should just let the user specify (source repo + destination repo) pairs; unfortunately that requires quite a noticeable redesign of the YAML format.)
|
A friendly reminder that this PR had no activity for 30 days. |
|
A friendly reminder that this PR had no activity for 30 days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Skopeo
synccommand by ensuring that image paths are preserved. This adds functionality while also addressing the issue where paths were previously flattened withpath.Base(destSuffix).RegistryNamefield torepoDescriptorfor better registry handling.getSubPathfunction to cleanly handle subpath extraction.imagesToCopyFromRegistryandfilterSourceReferencesto includeRegistryName.syncOptions.runto usegetSubPath.getSubPath.Resolves