DO NOT MERGE: Testing securejoin downgrade #25056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miloslav Trmač <[email protected]>
The root of filepath.* now must exist. Signed-off-by: Miloslav Trmač <[email protected]>
> go mod edit -replace github.com/opencontainers/runc=github.com/cyphar/[email protected] per opencontainers/runc#4590 . Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
…ifferent methods" This reverts commit 1d7ec1e. Signed-off-by: Miloslav Trmač <[email protected]>
Read the full one, not the truncated one Signed-off-by: Miloslav Trmač <[email protected]>
containers/image#2646 will track actually returning a meaningful error instead of these internal details. Signed-off-by: Miloslav Trmač <[email protected]>
> go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@wip-authentic Signed-off-by: Miloslav Trmač <[email protected]>
... because (podman system reset) will delete all of it, interfering with the test storing other data in the directory. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
> go mod edit -replace github.com/containers/storage=github.com/mtrmac/storage@securejoin-downgrade Signed-off-by: Miloslav Trmač <[email protected]>
go mod edit -replace github.com/containers/image/v5=github.com/mtrmac/image/v5@securejoin-downgrade Signed-off-by: Miloslav Trmač <[email protected]>
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This reverts commit d913224. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
securejoin-downgrade
branch
from
b7b2af2 to
3cc9a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?