Add GODEBUG option to use legacy filepath.EvalSymlinks() #25054
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
In go 1.23 filepath.EvalSymlink(path) behavior has changed and it returns an error if path is a Windows junction. The new behavior breaks some functionalities (see containers#24557). The GODEBUG option `winsymlink=0` allow to get run `EvalSymlink` with its legacy behavior. Signed-off-by: Mario Loriedo <[email protected]>
l0rd
force-pushed
the
fix-evalsymlink-windows-option2
branch
from
233696f to
e93a9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go 1.23 filepath.EvalSymlink(path) behavior has changed and now it returns an error if path is a Windows junction. The new behavior breaks some functionalities (see #24557).
With the GODEBUG option
winsymlink=0,EvalSymlinkuses its legacy behavior on Windows.Does this PR introduce a user-facing change?