[WIP] Forfun #20471
Closed
[WIP] Forfun #20471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix/update comments to remind developer the version applies to both Mac and Windows. * Add darwin-gvproxy target that operates identical to Windows release targets. * Fix hard-coded paths to use SRCBINDIR definition instead. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cevich
reviewed
Oct 24, 2023
Signed-off-by: Chris Evich <[email protected]> Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
forfun
branch
3 times, most recently
from
b9ae2ff to
7435e2a
Compare
cevich
reviewed
Oct 24, 2023
.cirrus.yml
Outdated
| # Default containers.conf helper_binaries_dir only searches global paths | ||
| - mkdir -p $HOME/.config/containers | ||
| - | | ||
| cat << EOF >> $HOME/.config/containers/containers.conf |
There was a problem hiding this comment.
Suggested change
| cat << EOF >> $HOME/.config/containers/containers.conf | |
| cat << EOF > $HOME/.config/containers/containers.conf |
baude
force-pushed
the
forfun
branch
14 times, most recently
from
45b9a8a to
c68ff60
Compare
Signed-off-by: Brent Baude <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?