-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #20050 from umohnani8/farm-build-2
Add podman farm build command
- Loading branch information
Showing
37 changed files
with
1,969 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| package farm | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/containers/common/pkg/config" | ||
| "github.com/containers/podman/v4/cmd/podman/common" | ||
| "github.com/containers/podman/v4/cmd/podman/registry" | ||
| "github.com/containers/podman/v4/cmd/podman/utils" | ||
| "github.com/containers/podman/v4/pkg/domain/entities" | ||
| "github.com/containers/podman/v4/pkg/farm" | ||
| "github.com/sirupsen/logrus" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type buildOptions struct { | ||
| buildOptions common.BuildFlagsWrapper | ||
| local bool | ||
| platforms []string | ||
| } | ||
|
|
||
| var ( | ||
| farmBuildDescription = `Build images on farm nodes, then bundle them into a manifest list` | ||
| buildCommand = &cobra.Command{ | ||
| Use: "build [options] [CONTEXT]", | ||
| Short: "Build a container image for multiple architectures", | ||
| Long: farmBuildDescription, | ||
| RunE: build, | ||
| Example: "podman farm build [flags] buildContextDirectory", | ||
| Args: cobra.ExactArgs(1), | ||
| } | ||
| buildOpts = buildOptions{ | ||
| buildOptions: common.BuildFlagsWrapper{}, | ||
| } | ||
| ) | ||
|
|
||
| func init() { | ||
| registry.Commands = append(registry.Commands, registry.CliCommand{ | ||
| Command: buildCommand, | ||
| Parent: farmCmd, | ||
| }) | ||
| flags := buildCommand.Flags() | ||
| flags.SetNormalizeFunc(utils.AliasFlags) | ||
|
|
||
| localFlagName := "local" | ||
| // Default for local is true and hide this flag for the remote use case | ||
| if !registry.IsRemote() { | ||
| flags.BoolVarP(&buildOpts.local, localFlagName, "l", true, "Build image on local machine as well as on farm nodes") | ||
| } | ||
| cleanupFlag := "cleanup" | ||
| flags.BoolVar(&buildOpts.buildOptions.Cleanup, cleanupFlag, false, "Remove built images from farm nodes on success") | ||
| platformsFlag := "platforms" | ||
| buildCommand.PersistentFlags().StringSliceVar(&buildOpts.platforms, platformsFlag, nil, "Build only on farm nodes that match the given platforms") | ||
|
|
||
| common.DefineBuildFlags(buildCommand, &buildOpts.buildOptions, true) | ||
| } | ||
|
|
||
| func build(cmd *cobra.Command, args []string) error { | ||
| // Return error if any of the hidden flags are used | ||
| for _, f := range common.FarmBuildHiddenFlags { | ||
| if cmd.Flags().Changed(f) { | ||
| return fmt.Errorf("%q is an unsupported flag for podman farm build", f) | ||
| } | ||
| } | ||
|
|
||
| if !cmd.Flags().Changed("tag") { | ||
| return errors.New("cannot create manifest list without a name, value for --tag is required") | ||
| } | ||
| opts, err := common.ParseBuildOpts(cmd, args, &buildOpts.buildOptions) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| // Close the logFile if one was created based on the flag | ||
| if opts.LogFileToClose != nil { | ||
| defer opts.LogFileToClose.Close() | ||
| } | ||
| if opts.TmpDirToClose != "" { | ||
| // We had to download the context directory. | ||
| // Delete it later. | ||
| defer func() { | ||
| if err = os.RemoveAll(opts.TmpDirToClose); err != nil { | ||
| logrus.Errorf("Removing temporary directory %q: %v", opts.TmpDirToClose, err) | ||
| } | ||
| }() | ||
| } | ||
| opts.Cleanup = buildOpts.buildOptions.Cleanup | ||
| iidFile, err := cmd.Flags().GetString("iidfile") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| opts.IIDFile = iidFile | ||
|
|
||
| cfg, err := config.ReadCustomConfig() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| defaultFarm := cfg.Farms.Default | ||
| if farmCmd.Flags().Changed("farm") { | ||
| f, err := farmCmd.Flags().GetString("farm") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defaultFarm = f | ||
| } | ||
|
|
||
| var localEngine entities.ImageEngine | ||
| if buildOpts.local { | ||
| localEngine = registry.ImageEngine() | ||
| } | ||
|
|
||
| ctx := registry.Context() | ||
| farm, err := farm.NewFarm(ctx, defaultFarm, localEngine) | ||
| if err != nil { | ||
| return fmt.Errorf("initializing: %w", err) | ||
| } | ||
|
|
||
| schedule, err := farm.Schedule(ctx, buildOpts.platforms) | ||
| if err != nil { | ||
| return fmt.Errorf("scheduling builds: %w", err) | ||
| } | ||
| logrus.Infof("schedule: %v", schedule) | ||
|
|
||
| manifestName := opts.Output | ||
| // Set Output to "" so that the images built on the farm nodes have no name | ||
| opts.Output = "" | ||
| if err = farm.Build(ctx, schedule, *opts, manifestName); err != nil { | ||
| return fmt.Errorf("build: %w", err) | ||
| } | ||
| logrus.Infof("build: ok") | ||
|
|
||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5a47b1eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
podman-next COPR build failed. @containers/packit-build please check.