Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconfigure golang indirect vulnerability support #201

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 25, 2024

Discovered by log analysis, Renovate will initially setup a vulnerable golang indirect dep for immediate PR creation. However, later on in its run, PR creation will be disabled by the global indirect-golang default setting (disabled). Extensive review of packageRules configuration shows no way to filter based on vulnerability status. This would be the only conceivable way to override the default.

Fix this by replacing the misleading/useless config. section with a comment block indicating that indirect golang vulnerabilities must be handled by hand.

Discovered by log analysis, Renovate will initially setup a vulnerable
golang indirect dep for immediate PR creation.  However, later on in
its run, PR creation will be disabled by the global indirect-golang
default setting (disabled).  Extensive review of `packageRules`
configuration shows no way to filter based on vulnerability status.
This would be the only conceivable way to override the default.

Fix this by replacing the misleading/useless config. section with a
comment block indicating that indirect golang vulnerabilities must be
handled by hand.

Signed-off-by: Chris Evich <[email protected]>
Copy link

github-actions bot commented Jun 25, 2024

Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 13aaf6100f67118c73956332e55ac54a61f5d411.

@cevich cevich merged commit 9c771bf into containers:main Jun 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant