PW pool management script adjustments #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 7d312ab881a8d2ae17ebe69119c35137b46e0aff. |
The file relates to dedicated hosts (DH), not persistent-workers (PW). Also, don't exit non-zero if there is an error-status. Rely on consumers of state file to take appropriate action. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
mac_pw_pool_adjustments
branch
from
7d312ab to
a4d857d
Compare
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's a4d857dfe2497ba47a7706e8522ae13406a512a7. |
Record the most recent status of all workers in a dedicated file. Intended for use by humans or other automation. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Previously it was possible to fail to launch any instances do to bugs and assumptions in the last-launch-time determination. Fix this by actually querying running instances, and searching for the most recent launch time. If there are no instances found, print a warning operators may observe. Also, fix missing `-t` option to several readarray() calls. Signed-off-by: Chris Evich <[email protected]>
For whatever reason, when a script that duplicates and redirects stdout/stderr to a log-file calls one of the management scripts, the log-file is truncated. Updating output functions to append their output seems to resolve this issue. Signed-off-by: Chris Evich <[email protected]>
The term "BUSY" implies the dedicated host is doing something else. This is not the case for staggering launches. Use a more descriptive status indicator for this. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
mac_pw_pool_adjustments
branch
from
a4d857d to
d1a3503
Compare
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's d1a3503a7fe1f50ebf3dc14217dee29d1d8367b9. |
If for whatever reason there is a failure in the query or search
for last-launch times, `$latest_launched` could be set to the current
time. This will ultimately result in no instances being launched. Fix
this by improved detection of an empty/null launch time in
`${launchtimes[@]}`.
Signed-off-by: Chris Evich <[email protected]>
|
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 723fbf10390372c3d2c6d433b043c74ecf187216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.