Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add benchmark results as a comment to the PR for each run #810

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jan 23, 2025

No description provided.

@Mossaka Mossaka closed this Jan 23, 2025
@Mossaka Mossaka deleted the add-comment-always branch January 23, 2025 23:09
@Mossaka Mossaka reopened this Jan 23, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criterion.rs Benchmark

Benchmark suite Current: fa97c4f Previous: 827fbd4 Ratio
end-to-end/wasmtime/wasi-demo-app:latest 124004569 ns/iter (± 6746666)
end-to-end/wasmtime/wasi-demo-oci:latest 78346152 ns/iter (± 2213222)
end-to-end/wasmedge/wasi-demo-app:latest 101187593 ns/iter (± 3149250)
end-to-end/wasmedge/wasi-demo-oci:latest 102132355 ns/iter (± 1114263)
end-to-end/wasmer/wasi-demo-app:latest 115436418 ns/iter (± 3434490)
end-to-end/wasmer/wasi-demo-oci:latest 105645882 ns/iter (± 2346837)
end-to-end/wamr/wasi-demo-app:latest 75697269 ns/iter (± 1136385)
end-to-end/wamr/wasi-demo-oci:latest 67889372 ns/iter (± 816466)

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP Throughput

Benchmark suite Current: 32abf45 Previous: 5088658 Ratio
HTTP RPS 20585.7443 req/s 19423.1136 req/s 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@jprendes
Copy link
Collaborator

jprendes commented Jan 24, 2025

I wonder why the memory benchmark and http latency results are missing

@Mossaka Mossaka force-pushed the add-comment-always branch from fa97c4f to 32abf45 Compare January 29, 2025 01:58
@jprendes
Copy link
Collaborator

That's odd, now nothing got commented?

@Mossaka Mossaka closed this Jan 29, 2025
@Mossaka Mossaka reopened this Jan 29, 2025
@github-actions github-actions bot added the T-CI label Jan 29, 2025
@Mossaka
Copy link
Member Author

Mossaka commented Jan 29, 2025

okay it looks like the comment feature is broken :(

@Mossaka
Copy link
Member Author

Mossaka commented Jan 29, 2025

@Mossaka Mossaka marked this pull request as draft January 30, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants