Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Remove ERC165 from diamonds constructor #400

Closed
wants to merge 2 commits into from
Closed

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Dec 19, 2023

remove updates to erc165 related data structure supportedInterfaces because the way we use diamondCut to upgrade our diamond we do not follow erc165

@dnkolegov
Copy link
Contributor

remove updates to erc165 related data structure supportedInterfaces because the way we use diamond-cut to upgrade our diamond we do not follow erc165

Maybe instead of removing the partially implemented interface, we should extend the implementation and support that interface ?

@raulk
Copy link
Contributor

raulk commented Dec 21, 2023

Yeah, agree, I think it's best to support ERC-165 as @dnkolegov says, unless I'm missing something. Tracking here: consensus-shipyard/ipc#498

@raulk raulk closed this Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ERC165 from diamonds
3 participants