This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
add pre-fund when there are less than three validators #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAtwill
approved these changes
May 4, 2023
adlrocha
commented
May 4, 2023
| // is too small (< 3), where if a new validator join and it doesn't have funds | ||
| // no new top-down checkpoints can be submitted, we add some balance also for | ||
| // non-initial validators. | ||
| if rt.curr_epoch() > 1 && validator_set.validators().len() < 4 { |
There was a problem hiding this comment.
@cryptoAtwill, just to double-check with you. I don't think we should merge this one, as there is a really simple attack where before there are more than four validators, any validator could continuously join and leave to drain 1 FIL of the gateway at a time. I think for now let's track the bug here and figure out a better way to solve it. Tracking the issue here: #103
|
@cryptoAtwill, unless you think otherwise, closing for now as the solution is too hacky and open to abuse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In order to remove the chicken-and-egg problem described in #96 we send some initial funds to the initial validators in a subnet. The issue is that if we spawn a subnet with just one validator, and we join from another validator, the second validator won't have any funds to submit top-down checkpoints, and as a super-majority is required to commit the checkpoint, there won't be any way for the joining validator to inject funds in the subnet to submit top-down checkpoints, stalling the checkpoint submission of top-down checkpoints for the subnet.
Proposal
For now, this PR introduces a work-around where some initial funds are also sent to joining validators when the number of validators is below
3, to prevent joining validators from not being able to submit a checkpoint for lack of funds. A more robust solution should be considered like using account abstraction or some kind of checkpoint submission subsidising system.