This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
FIX: to_eth_transaction set wrong input bytes #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consensus-shipyard/ipc#188
The
RawBytestype fromfvm_ipld_encodingstrikes again. Unlike into_eth_typed_transaction, into_eth_transactionI forgot thatMessage::paramscontains IPLD bytes that have to be decoded to get rid of the length prefix. The result was that theTransaction::inputfield returned from the Ethereum API did not match theEip1559TranasctionRequest::datafield the client sent, it was wrapped as an IPLD byte vector. This gets me every time 😞