This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
FM-427: HybridClient #462
Merged
FM-427: HybridClient #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
commented
Dec 8, 2023
| let query = query.clone(); | ||
| Box::pin(async move { client.unsubscribe(query.clone()).await }) | ||
| }) | ||
| .await; |
There was a problem hiding this comment.
Just realised again that if the unsubscription there is probably no need to repeat this loop, the new client would most likely not be subscribed to anything. There is hopefully no harm doing it though, and it keeps the error handling tucked away.
aakoshh
force-pushed
the
fm-427-ethapi-broken-socket
branch
from
3df7a2f to
792a4b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consensus-shipyard/ipc#159
Replaces the use of the
WebSocketClientin the Ethereum API facade with a newHybridClientthat wraps it and uses a normalHttpClientas well as aWebSocketClientunder the hood. The former should be more resilient as it doesn't maintain a persistent connection with CometBFT, while the latter is managed by aHybridClientDriverthat reconnects if it encounters the"failed to send to internal channel"error.With this solution the
ethapicontainer should heal itself and doesn't need to be restarted. In the event of the CometBFT connection being dropped, the active WebSocket subscriptions from our own clients should get an error when they try to consume the data, resulting in those connections being closed, forcing them to re-subscribe.