This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
New proposal logic #447
Merged
New proposal logic #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2023 22:56
…rd/fendermint into new-proposal-logic
cryptoAtwill
commented
Nov 29, 2023
added 2 commits
November 29, 2023 23:30
cryptoAtwill
commented
Nov 29, 2023
| if let Some(final_proposal) = r { | ||
| // this is possible due to delayed execution as the proposed height's data cannot be | ||
| // executed because they have yet to be executed. | ||
| return if last_committed_height == final_proposal { |
There was a problem hiding this comment.
@adlrocha Please help review this check, it is possible under delayed execution.
adlrocha
reviewed
Nov 29, 2023
There was a problem hiding this comment.
@cryptoAtwill, do you mind also propagating here some of the changes from Akosh here (or actually merging it here). Like e.g. the changes of the infra script: https://github.com/consensus-shipyard/fendermint/pull/435/files#diff-b901e8f9e6284b4e07255572105751b3e7b79683ddea1ff19bc9b06d30426b01R40, or including the comments and the parameter into the config.
The same applies to the max_proposal_range.
| for h in start..=end { | ||
| if let Some(Some(_)) = cache.get_value(h) { | ||
| return Ok(Some(h)); | ||
| Ok(cache.lower_bound().and_then(|lower_bound| { |
There was a problem hiding this comment.
I assume here that if the cache doesn't have the height it will go to fetch it from the parent, right?
adlrocha
reviewed
Nov 29, 2023
|
|
||
| tracing::debug!(first_non_null_height, candidate_height); | ||
| // an extra layer of delay | ||
| let r = |
There was a problem hiding this comment.
Suggested change
| let r = | |
| let proposal_height = |
adlrocha
approved these changes
Nov 29, 2023
maciejwitowski
pushed a commit
that referenced
this pull request
Nov 29, 2023
* remove look ahead in query topdown * use three pointers * up crate * fix error * Update fendermint/vm/topdown/src/sync/syncer.rs Co-authored-by: Akosh Farkash <[email protected]> * fix from integration testing * remove to_confirm pointer * restrict memory size * dont propose until interval reached * update latest height * split tendermint query to separete file * Update fendermint/vm/topdown/src/sync/syncer.rs Co-authored-by: adlrocha <[email protected]> * fix test linting * fix tests * more tests * check hash when executing * sync * sort by nonce * fmt * more unit tests * New proposal logic (#447) * new proposal logic * fmt * fix typo * minor changes * adding check * ignore proposal height * Fix type * expose config params --------- Co-authored-by: Alfonso de la Rocha <[email protected]> --------- Signed-off-by: Alfonso de la Rocha <[email protected]> Co-authored-by: Akosh Farkash <[email protected]> Co-authored-by: adlrocha <[email protected]> Co-authored-by: Alfonso de la Rocha <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix based on review feedbacks.