Adds exclusion_source #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cally from a list of artifact coordinates as passed to maven_install
vinnybod
reviewed
Apr 30, 2024
Comment on lines
+301
to
+304
| exclusion_source_json_strings = [ | ||
| _json.write_artifact_spec(artifact) | ||
| for artifact in parse.parse_artifact_spec_list(exclusion_source) | ||
| ] |
There was a problem hiding this comment.
I understand the need for the separate field on java_export, but I wonder if it would make sense to merge the two and just passing a single exclusions dict to pom_file?
At a high level:
parse and filter the exclusion_source list so it only includes dependencies with exclusions
convert the list so it is a dict in the same form as exclusions
merge the two dicts and pass to pom_file
There was a problem hiding this comment.
Good question. It's not straightforward:
pom_file'sexclusionhas labels for keys, not strings. I think that makes it safer to use so I'm not sure we should change that. If we tried moving the computation of the key outside ofpom_fileit would have to be a label, and we'd get back to needed to encode in snake case like we to do, and guess the repo (@maven).- if we we move to stings as keys, and move the computation of the key outside of
pom_file, we wouldn't have access to the list of dependenciesexpanded_maven_depsthat we use to filter the exclusions, so we'd likely forego the filtering and thenpom_filewould need to ignore irrelevant dependencies (again a bit more error prone for explicitly added exclusions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exclusion_source attribute to java_export so that exclusions can be extracted automatically from a list of artifact coordinates as passed to maven_install.