Cherry-pick QueryLogger #9681 #9689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use QueryLogger for logging queries * anonymize processed queries * logging for unparsable queries * anonymized query handling logs * anonymized received queries * anonymized streaming query * checkstyle * prevent exception from querylogger * don't include statement text in exception message * don't include statement text in exception messages * fix tests * fix tests * fix tests * checkstyle * checkstyle * fix parser test * fix tests * checkstyle * restore ability to print errors in CLI * checkstyle * checkstyle * fix error code * One more fix for RestoreCommandsCompactor * Fix style bug Co-authored-by: Alan Sheinberg <[email protected]>
jnh5y
reviewed
Nov 4, 2022
| @@ -74,12 +74,20 @@ def _parse_changelog_with_duplicates(filename, release=None): | |||
|
|
|||
| ## verify header | |||
| if _is_header(line): | |||
| print('line {0} is header'.format(line)) | |||
There was a problem hiding this comment.
@vpapavas does this file need to change?
jnh5y
reviewed
Nov 4, 2022
| @Override | ||
| public String toString() { | ||
| return buildMessage(rawMessage, "<retracted>"); | ||
| } |
There was a problem hiding this comment.
@AlanConfluent @vpapavas Does this need to be in the final PR?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick #9681
There were some conflicts, I addressed by removing code that is not available in 0.28.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist