Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMF-1630: Add Flink Operation Group #3021

Merged
merged 9 commits into from
Feb 5, 2025
Merged

AMF-1630: Add Flink Operation Group #3021

merged 9 commits into from
Feb 5, 2025

Conversation

bcuii
Copy link
Contributor

@bcuii bcuii commented Jan 31, 2025

Release Notes

New Features

  • Add Flink operation group to confluent iam ip-filter commands

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Add Flink operation group to iam ip-filter commands.

Blast Radius

Since this is an optional parameter, it will have no direct effect on functionality. It only directly affects the iam ip-filter create and iam ip-filter update help tips.

References

https://confluentinc.atlassian.net/browse/AMF-1532

Test & Review

See test section in https://github.com/confluentinc/airlock-cli/pull/173

@bcuii bcuii requested a review from a team as a code owner January 31, 2025 19:29
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Member

@brianstrauch brianstrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few tests are failing.

@bcuii bcuii requested a review from brianstrauch February 4, 2025 17:55
@bcuii bcuii merged commit a73d732 into main Feb 5, 2025
2 checks passed
@bcuii bcuii deleted the amf-1630 branch February 5, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants