Remove support for python 3.8 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcelotrevisani
commented
Nov 13, 2024
•
marcelotrevisani
commented
- Drop support for python 3.8 and 3.9
- Update type annotations to Python 3.9+ syntax
- Replace legacy type annotations with Python 3.9+ syntax for improved readability and conciseness.
- Update the pre-commit hook version for ruff to v0.7.3 for linting purposes.
for more information, see https://pre-commit.ci
Replace legacy type annotations with Python 3.9+ syntax for improved readability and conciseness. Additionally, update the pre-commit hook version for ruff to v0.7.3 for linting purposes. Signed-off-by: Marcelo Trevisani <[email protected]>
Set Sphinx workflow to use Python 3.12 explicitly and removed testing for Python 3.9 in the tests workflow. Signed-off-by: Marcelo Trevisani <[email protected]>
Replaced the type hint for the `__instance` attribute in `CLIConfig` from `"CLIConfig"` to `Self` to improve type checking and readability. Signed-off-by: Marcelo Trevisani <[email protected]>
Added a fallback mechanism to import 'TypeVar' and define 'Self' if 'Self' is not available in the typing module. This ensures compatibility with older Python versions that do not support 'Self'. Signed-off-by: Marcelo Trevisani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.