patch configure to link -lpthread on windows

[brendanf]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[brendanf]

@conda-forge-admin, please rerender

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

[brendanf]

@conda-forge-admin, please rerender

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

• The source section contained an unexpected subsection name. patch is not a valid subsection name.

For recipe/meta.yaml:

• Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [42].

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

• Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [43].

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

[brendanf]

I also opened a PR to patch this upstream r-lib/ps#182

[brendanf]

@conda-forge/r ready for review. Changes welcome.

[brendanf]

Fixes #27

[brendanf]

@conda-forge-admin, please rerender

[mfansler]

Thanks for working on this! ❤️

As long as the patch gets -pthread flag included during link, then the dependencies shouldn't need adjustment.

[brendanf]

@mfansler You are right, that worked.

[brendanf]

The reason I originally added libwinpthreads as a requirement is that I just recently submitted a PR for a new package that also uses -lpthread in Windows and got an error that it was overdepending on libwinpthread-1.dll, which I resolved by adding the package to run:. Is staged recipes running a different build process?

[mfansler]

The reason I originally added libwinpthreads as a requirement is that I just recently submitted a PR for a new package that also uses -lpthread in Windows and got an error that it was overdepending on libwinpthread-1.dll, which I resolved by adding the package to run:. Is staged recipes running a different build process?

Yes, there is an interim period when migrating R versions that staged-recipes still follows the previous standards, while migrated feedstocks should be following the latest practice. This is particularly stark difference as Windows is both switching to UCRT and jumping from R 4.1 to R 4.3/4.4. Plus, this migration has gone on far longer than the last few. Hopefully, we can start wrapping up soonish.

[mfansler]

Thanks again!