Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand lief <0.15 patch to catch latest conda-build 25.1.1 #948

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 17, 2025

#947 tightened the patch, but the latest build of conda-build 25.1.1 (build 1), which only pinned <0.16, was published after the timestamp_le cutoff, so mac builds are still running with py-lief 0.15 and failing

@minrk minrk requested a review from a team as a code owner January 17, 2025 08:32
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy xhochy merged commit d2ebc56 into conda-forge:main Jan 17, 2025
3 checks passed
@minrk minrk deleted the conda-build-lief-date branch January 17, 2025 09:33
@tkelman
Copy link
Member

tkelman commented Jan 17, 2025

Thanks for catching this. I also didn't notice that "25.11.1" was a typo.

CI on main failed due to what I think is an http error, could someone restart it? Likewise a lot of the latest CI runs on the conda-build feedstock timed out, that were trying to deploy a new build of 25.1.1 with a py-lief <0.15 constraint

@xhochy
Copy link
Member

xhochy commented Jan 18, 2025

Triggered a rerun and that succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants