-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch old nvcc_*, cudnn, and libcufile packages #920
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel! 🙏
Had a minor suggestion that may help with the pre-commit error
The reason this is still draft is that I mean to investigate and decide whether I want to add a third patch for libcufile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @carterbox
Thanks Daniel! 🙏 Also thanks Keith for the review! 🙏 |
Checklist
generate_patch_json.py
.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.Closes conda-forge/cudnn-feedstock#98
Closes conda-forge/nvcc-feedstock#108
Closes conda-forge/libcufile-feedstock#25