Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Comments only) Add more context about cryptography pins in pyopenssl #919

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Dec 3, 2024

Implements #913 (comment)

I cherry-picked @IzerOnadimQC's comments and then adapted my comment to explain the rationale for maintaining monotonicity. CC @ocefpaf

I only modify comments, I don't change anything consequential.

@maresb maresb requested a review from a team as a code owner December 3, 2024 09:10
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@IzerOnadimQC
Copy link
Contributor

Thanks!

@ocefpaf ocefpaf merged commit 3b14946 into conda-forge:main Dec 3, 2024
3 checks passed
@ocefpaf
Copy link
Member

ocefpaf commented Dec 3, 2024

Thanks @IzerOnadimQC for the detailed explanation of the problem!

@maresb maresb deleted the pyopenssl-comments branch December 3, 2024 09:22
@ReimarBauer
Copy link

That is strange now I get

  • cryptography 44.0.0 py311hafd3f86_0 conda-forge
  • pyopenssl 21.0.0 pyhd8ed1ab_0 conda-forge

and it fails again https://github.com/Open-MSS/MSS/actions/runs/12122317805/job/33854056820

@maresb
Copy link
Contributor Author

maresb commented Dec 3, 2024

@ReimarBauer, it's loading the environment from cache. Do you have permissions to delete the cache files? (If not, there are some dirty tricks to bust the cache from the workflow YAML.)

@ReimarBauer
Copy link

@ReimarBauer, it's loading the environment from cache. Do you have permissions to delete the cache files? (If not, there are some dirty tricks to bust the cache from the workflow YAML.)

good catch. But it gives the next question. How can I recognize that I need to delete the cache?

@ReimarBauer
Copy link

result is and it works again

  • cryptography 43.0.3 py311h544b224_0 conda-forge
  • pyopenssl 24.2.1 pyhd8ed1ab_2 conda-forge

@maresb
Copy link
Contributor Author

maresb commented Dec 3, 2024

How can I recognize that I need to delete the cache?

Generally you shouldn't have to worry about this, and there are sane defaults for the cache key. The issue in this particular case is that adjusting the repodata is a fairly extreme (although unfortunately not unheard-of) intervention, and there's currently no cache busting mechanism for it. I think that implementing something would be pretty difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants