Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues 89 #92

Merged
merged 9 commits into from
Sep 25, 2019
Merged

fix issues 89 #92

merged 9 commits into from
Sep 25, 2019

Conversation

mgsolid
Copy link

@mgsolid mgsolid commented Jun 24, 2019

#89

fix issues 89
8f9cb44 
Signed-off-by: Ye Yang <[email protected]>
vito
vito requested changes Jun 26, 2019
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this, but I think it needs a bit more. 🙂 Not sure if you're up for it since this started off so simple.

driver/git.go Outdated Show resolved Hide resolved
@mgsolid
Copy link
Author

mgsolid commented Jul 30, 2019

@vito please help to take a look

retry for 3 times
8958a2f 
Signed-off-by: Ye Yang <[email protected]>
vito
vito approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

vito
vito requested changes Aug 15, 2019
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, while resolving the merge conflicts I noticed there's another unbounded for { loop in Set() - would you mind limiting that loop too for consistency?

fix another loop
6ff76f9 
Signed-off-by: Ye Yang <[email protected]>
@mgsolid
Copy link
Author

mgsolid commented Aug 21, 2019

fixed anther loop.

@mgsolid
Copy link
Author

mgsolid commented Aug 29, 2019

@vito could you take a look, the new change is satisfying your request?

Jamie Klassen and others added 6 commits September 4, 2019 11:58
fix function name typo
46f6783 
also run gofmt

Signed-off-by: Jamie Klassen <[email protected]>
Co-authored-by: James Thomson <[email protected]>
Merge pull request concourse#101 from concourse/fix-typo
790e42e 
fix function name typo
fix issues 89
e7e8510 
Signed-off-by: Ye Yang <[email protected]>
retry for 3 times
8550087 
Signed-off-by: Ye Yang <[email protected]>
fix another loop
602e241 
Signed-off-by: Ye Yang <[email protected]>
merged master
7fbcc9b
@mgsolid
Copy link
Author

mgsolid commented Sep 9, 2019

Actually, while resolving the merge conflicts I noticed there's another unbounded for { loop in Set() - would you mind limiting that loop too for consistency?

fixed and rebased upstream master. thanks.

@mgsolid mgsolid closed this Sep 9, 2019
@mgsolid mgsolid reopened this Sep 9, 2019
vito
vito approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@vito vito merged commit 90b999a into concourse:master Sep 25, 2019
@jamieklassen jamieklassen added this to the v5.6.0 milestone Sep 30, 2019
jamieklassen pushed a commit to concourse/concourse that referenced this pull request Sep 30, 2019
document semver git driver infinite loop fix
309b815 
documents concourse/semver-resource#92

Signed-off-by: Jamie Klassen <[email protected]>
Co-authored-by: James Thomson <[email protected]>
@dimaj dimaj mentioned this pull request Jan 29, 2020
Open
@xtremerui xtremerui mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchaoli evanchaoli evanchaoli left review comments

@vito vito vito approved these changes

Assignees
No one assigned
Labels
release/documented
Projects
None yet
Milestone
v5.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgsolid @vito @evanchaoli @jamieklassen