Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use maxsplit=1 #17571

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

maitrey
Copy link
Contributor

@maitrey maitrey commented Jan 14, 2025

Changelog: Fix: Fix Git is_dirty detection of excluded files with paths.
Docs: Omit

I have a file that has a space in its name. In the conan export method I use it like this:

def export(self):
        git = Git(self, self.recipe_folder, excluded=["src/file Component Toolchain.prj"])
        git.coordinates_to_conandata()

and this fails because of the split:

lines = [line.split()[1] for line in lines if line]

Closes #17570

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@AbrilRBS AbrilRBS self-assigned this Jan 14, 2025
@AbrilRBS AbrilRBS added this to the 2.12.0 milestone Jan 14, 2025
@maitrey maitrey force-pushed the feature/fixspaceinfilename branch from c7100bb to 48517c7 Compare January 14, 2025 13:54
@AbrilRBS AbrilRBS merged commit 8ea8174 into conan-io:develop2 Jan 14, 2025
33 checks passed
@maitrey maitrey deleted the feature/fixspaceinfilename branch January 14, 2025 15:32
memsharded pushed a commit to memsharded/conan that referenced this pull request Jan 15, 2025
* Updated to use maxsplit=1

* Add tests, unquote paths with spaces

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
memsharded pushed a commit to memsharded/conan that referenced this pull request Jan 19, 2025
* Updated to use maxsplit=1

* Add tests, unquote paths with spaces

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
memsharded added a commit that referenced this pull request Jan 21, 2025
* extra patches path

* Update conan/tools/files/patches.py

Co-authored-by: Andrey Filipenkov <[email protected]>

* fix docstring of Environment.vars() (#17521)

fix docstring of vars()

* GnuToolchain's make_args handle empty values correctly (#17532)

test

* Change replace_in_file to return True on success (#17531)

- was inconsistent before: returned False if the
  pattern was not found (with strict off), otherwise None

* upgrade bottle version (#17534)

* better traces and msgs (#17517)

* better traces and msgs

* fix tests

* Feature/workspace api (#17501)

* working in workspace_api

* fixed loader + run() error

* update webtest testing version (#17537)

* proposing new --format=<format> --out-file=<file.ext> feature (#17507)

* proposing new --format=file.ext feature

* change approach and some simplifications

* remove unused

* minor changes

* minor changes

* simplify a bit

* fix format

* minor changes

* fix

* move colorama deinit/reinit

* add out-file only if formatters

* revert

* wip

* do not deinit/reinit if not tty

* clean import

* minor changes

---------

Co-authored-by: czoido <[email protected]>

* Test/remote login (#17552)

* new test for remote_login

* unittest->pytest

* Keep sessions around between each ConanRequester (#17455)

* Keep sessions around between each ConanRequester

Avoid creating a new session for each ConanRequester instance, this
helps a lot with performance, as it avoids the overhead duplicate handshakes

* Patch new cached value on ConanRequester tests

* Modify adapter as needed

* Fix tests

* Name

* Update conans/client/rest/conan_requester.py

* Refactor requester tests

* Reinit is not part of this PR

* Refactor request usage out of app

* Make max_retries a local variable

* Add rest of posible `ConanBasicApp` usages (#17555)

Add rest of posible ConanBasicApp usages

* Improve typing information in remove sub API (#17564)

As the API actually accepts the remote to be `None`, this should also be
reflected in the type information in order to support users.

* small refactor to PkgConfigDeps (#17568)

* Updated to use maxsplit=1 (#17571)

* Updated to use maxsplit=1

* Add tests, unquote paths with spaces

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>

* refactor moving model conans->conan (#17572)

* refactor moving model conans->conan

* fix tests

* allow non trim_conandata

* removed print

---------

Co-authored-by: Andrey Filipenkov <[email protected]>
Co-authored-by: Andrey Filipenkov <[email protected]>
Co-authored-by: Ernesto de Gracia Herranz <[email protected]>
Co-authored-by: mrbean-bremen <[email protected]>
Co-authored-by: czoido <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Co-authored-by: Martin Lambertsen <[email protected]>
Co-authored-by: maitrey <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Files with space in name fails when creating an object of Git with excluded list
4 participants