Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make minor code semantics changes in core module #823

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Make minor code semantics changes in core module #823

merged 2 commits into from
Jan 2, 2025

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Dec 30, 2024

This PR takes care of minor updates to docstrings and code semantics. GTG from my side!

constantinpape
constantinpape reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. The only thing I noticed is that you're removing Returns in some doc-strings where I think they should be kept.

micro_sam/models/sam_3d_wrapper.py Outdated Show resolved Hide resolved
micro_sam/models/simple_sam_3d_wrapper.py Outdated Show resolved Hide resolved
micro_sam/training/trainable_sam.py Outdated Show resolved Hide resolved
@anwai98
Copy link
Contributor Author

anwai98 commented Dec 31, 2024

I thought of removing the return types for nn.Module as it kind of does not make a clear sense in terms of the forward pass. However, I see the value in keeping them as the cases above are a bit more complicated and document things well. I'll restore them!

@anwai98
Copy link
Contributor Author

anwai98 commented Jan 2, 2025

This is GTG from my side!

cc: @constantinpape

@constantinpape constantinpape merged commit f20416f into dev Jan 2, 2025
2 of 3 checks passed
@constantinpape constantinpape deleted the rf-semantics branch January 2, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anwai98 @constantinpape