Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue are you addressing?
Closes #51
How have you addressed the issue?
A new method has been added to validate parameters. It is called
For
handler to ensure that all worksharing-for loops have valid parameters.ParallelRegion
to ensure all parallel regions have valid parameters.Taskloop
to ensure all taskloops have valid parameters.How have you tested your patch?
Two new tests have been added:
Absent_params_shouldnt_except
, which uses all default parameters with affected methods to ensure that the checks do not affect a lack of parameters.Invalid_params_should_except
, which has 100% coverage of theValidateParams
method to ensure that all paths are valid.