Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate DotMP input parameters #98

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Validate DotMP input parameters #98

merged 4 commits into from
Oct 25, 2023

Conversation

computablee
Copy link
Owner

Which issue are you addressing?

Closes #51

How have you addressed the issue?

A new method has been added to validate parameters. It is called

  1. Within the internal For handler to ensure that all worksharing-for loops have valid parameters.
  2. Within a ParallelRegion to ensure all parallel regions have valid parameters.
  3. Within a Taskloop to ensure all taskloops have valid parameters.

How have you tested your patch?

Two new tests have been added:

  1. Absent_params_shouldnt_except, which uses all default parameters with affected methods to ensure that the checks do not affect a lack of parameters.
  2. Invalid_params_should_except, which has 100% coverage of the ValidateParams method to ensure that all paths are valid.

@computablee computablee changed the title Features Validate DotMP input parameters Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6461494) 99.44% compared to head (9cf9f31) 99.54%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   99.44%   99.54%   +0.09%     
==========================================
  Files          12       12              
  Lines        1080     1096      +16     
  Branches      103      108       +5     
==========================================
+ Hits         1074     1091      +17     
+ Partials        6        5       -1     
Files Coverage Δ
DotMP/Exceptions.cs 100.00% <100.00%> (ø)
DotMP/Parallel.cs 98.96% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@computablee computablee merged commit 578e8d6 into main Oct 25, 2023
5 checks passed
@computablee computablee deleted the features branch October 27, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need more rigorous error checking
1 participant