Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU functionality #126

Merged
merged 90 commits into from
Nov 27, 2023
Merged

Add GPU functionality #126

merged 90 commits into from
Nov 27, 2023

Conversation

computablee
Copy link
Owner

Which issue are you addressing?

This issue addresses a previous discussion on adding GPU support.

How have you addressed the issue?

Minimal GPU support is now supported via the ILGPU project. The approach that DotMP takes is not dissimilar to SYCL in its memory semantics, but tries to be faithful to the CPU API in how kernels are dispatched. More details will be added to the wiki.

How have you tested your patch?

There is an extremely minimal set of tests in the DotMP-Tests folder for GPU. This will need to be updated in the future.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2db30d0) 99.19% compared to head (6fbab81) 99.09%.

Files Patch % Lines
DotMP/GPU/Buffer.cs 96.96% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   99.19%   99.09%   -0.10%     
==========================================
  Files          12       13       +1     
  Lines        1360     1431      +71     
  Branches      146      155       +9     
==========================================
+ Hits         1349     1418      +69     
  Misses          5        5              
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@computablee computablee marked this pull request as draft November 26, 2023 08:35
@computablee computablee self-assigned this Nov 26, 2023
@computablee computablee marked this pull request as ready for review November 27, 2023 02:06
@computablee computablee merged commit 56ec974 into main Nov 27, 2023
3 of 5 checks passed
@computablee computablee deleted the release/v2.0.0 branch November 27, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant