Add error checking to ForCollapse #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 99.13% 99.22% +0.09%
==========================================
Files 12 12
Lines 1270 1291 +21
Branches 134 137 +3
==========================================
+ Hits 1259 1281 +22
Misses 5 5
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue are you addressing?
Makes progress towards #115
How have you addressed the issue?
Overflow checking is now performed within
ForCollapseloops, throwing aTooManyIterationsExceptionif there are more thanint.MaxValuetotal iterations to execute. Additionally, proper argument checking is now performed onForCollapseloops.How have you tested your patch?
A new test has been added to check for this situation, which passes.