This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
forked from lesstif/php-jira-rest-client
-
Notifications
You must be signed in to change notification settings - Fork 0
Sync complex package with main repository changes #3
Open
hgriga
wants to merge
16
commits into
complex-gmbh:main
Choose a base branch
from
lesstif:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tokmanb <[email protected]>
[ci skip] [skip ci] Co-authored-by: StyleCI Bot <[email protected]>
* add default values to properties not sent * release date is nullable * name cannot be nullable --------- Co-authored-by: martin.reinfandt <[email protected]>
* add default values to properties not sent * release date is nullable * name cannot be nullable * adjust constructor of version so name can only be a string * require a minimum of latest version of json mapper to support class-string syntax --------- Co-authored-by: martin.reinfandt <[email protected]>
- fixed #523 added createdDate property
[ci skip] [skip ci] Co-authored-by: StyleCI Bot <[email protected]>
e.g. to remove a previous selection from a checkbox field
[ci skip] [skip ci] Co-authored-by: StyleCI Bot <[email protected]>
* Changed project name * Can we use the original project name? * feat: #WPLZ-166 - introduce timeout --------- Co-authored-by: Peter Majmesku <[email protected]>
Co-authored-by: Tomáš Lipenský <[email protected]>
…#535) * Create BoardResult.php - Create a new class to hold the entire result data of the response returned from the "/rest/agile/1.0/board" endpoint - The approach is very similar to how the existing IssueService->search() function works already * Update BoardService.php - Instead of updating the existing getAllBoards() method and create a breaking change, I introduced a new method getBoards() - This method calls to the same "/rest/agile/1.0/board" endpoint as getAllBoards() but it maps the value into the newly created BoardResult class rather than ArrayObject. - This allows the developer to determine if there are more results past the initial 50 on the first page, and get additional pages if necessary * Update BoardTest.php - Created a new test method which performs the same test as the get_all_boards() test but using the updated result object instead * Update README.md Add information about how to use the new getBoards() method to retrieve the entire list of board results * Add periods to end of comments Added these in order to pass StyleCI PR checks * Rename BoardResult to more generic PaginatedResult I realized other methods in BoardService also did not have proper pagination built in. We will reuse this class in a more generic way for other methods such as getSprintsForBoard() * Update BoardService.php - Update our new getBoards() method to return PaginatedResult instead of BoardResult - Add new method getSprintsForBoard() which has support for pagination and uses PaginatedResult
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complex package is currently 16 commits behind the main repository.