[wip] Turn on cppyy for Ubuntu 22.04 arm jobs ci #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
requested changes
Jan 24, 2025
mcbarton
force-pushed
the
Add-Ubuntu-22.04-arm-support-to-cppyy
branch
from
7d17195 to
5db93d9
Compare
|
@aaronj0 Thank you for your work adding the Valgrind suppressions to the Ubuntu 24.04 x86 PR. Can you do the same for this Ubuntu 22.04 arm PR? |
|
@aaronj0 I've fixed the merge conflict so you can carry on with your Valgrind fix. |
aaronj0
force-pushed
the
Add-Ubuntu-22.04-arm-support-to-cppyy
branch
from
cb1d63f to
c75c204
Compare
aaronj0
force-pushed
the
Add-Ubuntu-22.04-arm-support-to-cppyy
branch
4 times, most recently
from
6aacb76 to
68abd65
Compare
This stems from a mismatched free() context causing 3 errors with all LLVM versions (13, 17, 18, 19). The suppression files are made seperate so we do not regress mismatched free() memory errors on non-ARM builds
aaronj0
force-pushed
the
Add-Ubuntu-22.04-arm-support-to-cppyy
branch
from
aa256c7 to
466885b
Compare
aaronj0
approved these changes
Jan 28, 2025
| @@ -818,6 +825,7 @@ def z(self): | |||
| assert a.m_2 == 42 | |||
| assert a.m_3 == 67 | |||
|
|
|||
| @mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") | |||
There was a problem hiding this comment.
I suspect the xfail tag here is wrong.
It should be
Suggested change
| @mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") | |
| @mark.xfail(run=False, condition=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") |
Also, if this function passes in all other platforms, then the reason might not be related to toString.
| @@ -905,6 +913,7 @@ def z(self): | |||
| assert a.m_2 == 88 | |||
| assert a.m_3 == -11 | |||
|
|
|||
| @mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") | |||
| @@ -1276,6 +1285,7 @@ class D(B): | |||
| assert inst.fun1() == val1 | |||
| assert inst.fun2() == inst.fun1() | |||
|
|
|||
| @mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") | |||
| @@ -1517,6 +1527,7 @@ def getValue(self): | |||
| gc.collect() | |||
| assert ns.Component.get_count() == 0 | |||
|
|
|||
| @mark.xfail(run=not IS_CLANG_DEBUG, reason="Crashes with ClangRepl with 'toString not implemented'") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make it so you can build cppyy on Ubuntu 22.04 arm.