Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 arm runners to ci #463

Merged
merged 19 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/Ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,42 @@ jobs:
cling-version: '1.0'
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu24-arm-gcc12-clang-repl-19
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '19'
cling: Off
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu24-arm-gcc12-clang-repl-18
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '18'
cling: Off
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu24-arm-gcc12-clang-repl-17
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '17'
cling: Off
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu24-arm-gcc12-clang-repl-16
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '16'
cling: Off
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"
- name: ubu24-arm-gcc9-clang13-cling
os: ubuntu-24.04-arm
compiler: gcc-9
clang-runtime: '13'
cling: On
cling-version: '1.0'
llvm_enable_projects: "clang"
llvm_targets_to_build: "host;NVPTX"

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -337,6 +373,33 @@ jobs:
clang-runtime: '13'
cling: On
cling-version: '1.0'
- name: ubu24-arm-gcc12-clang-repl-19
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '19'
cling: Off
- name: ubu24-arm-gcc12-clang-repl-18
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '18'
cling: Off
- name: ubu24-arm-gcc12-clang-repl-17
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '17'
cling: Off
- name: ubu24-arm-gcc12-clang-repl-16
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '16'
cling: Off
cppyy: Off
- name: ubu24-arm-gcc9-clang13-cling
os: ubuntu-24.04-arm
compiler: gcc-9
clang-runtime: '13'
cling: On
cling-version: '1.0'

steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/emscripten.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ jobs:
llvm_enable_projects: "clang;lld"
llvm_targets_to_build: "WebAssembly"
emsdk_ver: "3.1.45"
- name: ubu24-arm-gcc12-clang-repl-19-emscripten
os: ubuntu-24.04-arm
compiler: gcc-12
clang-runtime: '19'
cling: Off
llvm_enable_projects: "clang;lld"
llvm_targets_to_build: "WebAssembly"
emsdk_ver: "3.1.45"
- name: osx15-arm-clang-clang-repl-19-emscripten
os: macos-15
compiler: clang
Expand Down
17 changes: 16 additions & 1 deletion lib/Interpreter/CppInterOp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2828,7 +2828,15 @@ namespace Cpp {
#define DEBUG_TYPE "exec"

std::array<char, 256> buffer;
std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd, "r"), pclose);
struct file_deleter
{
void operator()(FILE* fp)
mcbarton marked this conversation as resolved.
Show resolved Hide resolved
{
pclose(fp);
}
};
using file_pointer = std::unique_ptr<FILE, file_deleter>;
mcbarton marked this conversation as resolved.
Show resolved Hide resolved
file_pointer pipe{popen(cmd, "r")};
mcbarton marked this conversation as resolved.
Show resolved Hide resolved
LLVM_DEBUG(dbgs() << "Executing command '" << cmd << "'\n");

if (!pipe) {
mcbarton marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -3437,7 +3445,14 @@ namespace Cpp {
}

mcbarton marked this conversation as resolved.
Show resolved Hide resolved
class StreamCaptureInfo {
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wignored-attributes"
#endif
std::unique_ptr<FILE, decltype(std::fclose)*> m_TempFile;
#if defined(__GNUC__)
#pragma GCC diagnostic pop
mcbarton marked this conversation as resolved.
Show resolved Hide resolved
#endif
int m_FD = -1;
int m_DupFD = -1;

Expand Down
Loading