[WIP] fixes to build for WASM #76
Conversation
| endif() | ||
| else() | ||
| set(Python_INCLUDE_DIRS | ||
| "${CMAKE_PREFIX_PATH}/include/python3.11" |
There was a problem hiding this comment.
Don't want Python_INCLUDE_DIRS to be set for a particular python version. The ci has version 3.11 for non wasm jobs, but we will want cppyy to support more than just that version. I plan to make this as part of the ci soon. Also given wasm support is constantly change, its probably best to look at using the latest python version for this work.
|
|
||
| if (NOT Python_Development_FOUND) | ||
| message(FATAL_ERROR "Python development package not found and python component required") | ||
| if(NOT EMSCRIPTEN) |
There was a problem hiding this comment.
I would rather have if (emscripten) then else as that is more clear
| @@ -28,6 +40,12 @@ file (GLOB cppyy_src src/*.cxx) | |||
|
|
|||
| add_library(cppyy SHARED ${cppyy_src}) | |||
|
|
|||
| if (EMSCRIPTEN) | |||
| target_link_options(cppyy | |||
There was a problem hiding this comment.
I prefer set_target_properties and to use the link_flags option, and we can drop the CMAKE_SHARED_LIBRARY_CREATE_C_FLAGS "-s SIDE_MODULE=1") and set(CMAKE_SHARED_LIBRARY_CREATE_CXX_FLAGS "-s SIDE_MODULE=1") and put as compile_flags for the cppyy target.
No description provided.