Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all model input in RobotModelObject.__init__ #21

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

yck011522
Copy link
Contributor

I'm not sure since which version of compas that the Scene will no longer pass model as parameter to the init of RobotModelObject. This is pass as item now. The model is set at SceneObject.item and previously @PingHsunTsai have already made it available at BaseRobotModelObject.model.

That change had not been updated to the other RobotModelObjects at Rhino GH and blender. So here it is.

This fixes the error message:

Message: init() takes exactly 2 arguments (4 given)

Traceback:
line 116, in add, “C:\Users\alici\AppData\Roaming\McNeel\Rhinoceros\7.0\scripts\compas\scene\scene.py”
line 10, in , “C:\Users\alici\AppData\Local\Temp\TempScript.py”

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you tested that this works, then let's go ahead and merge/release!

@yck011522 yck011522 merged commit 5cafe96 into main Sep 26, 2024
14 checks passed
@yck011522 yck011522 deleted the bugfix/remove-model-from-SceneObjects-init branch September 26, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants