Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed plugin not called in NurbsSurface #1418

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

chenkasirer
Copy link
Member

Fixes #1417

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.71%. Comparing base (3b38816) to head (a761aca).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/compas/geometry/surfaces/nurbs.py 0.00% 1 Missing ⚠️
src/compas/geometry/surfaces/surface.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   61.72%   61.71%   -0.02%     
==========================================
  Files         207      207              
  Lines       22302    22302              
==========================================
- Hits        13767    13763       -4     
- Misses       8535     8539       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -392,7 +392,7 @@ def from_native(cls, surface):
:class:`compas.geometry.NurbsSurface`

"""
raise NotImplementedError
return nurbssurface_from_native(cls, surface)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenkasirer could you make the same change for Surface?

@chenkasirer chenkasirer merged commit 7bbe6ac into main Jan 7, 2025
16 of 18 checks passed
@chenkasirer chenkasirer deleted the nurbssurfac_from_native branch January 7, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

surface_to_compas doesn't work
2 participants