Fix bug in serialisation of AttributeView #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
- Coverage 60.70% 60.68% -0.02%
==========================================
Files 207 207
Lines 22262 22265 +3
==========================================
- Hits 13514 13512 -2
- Misses 8748 8753 +5 ☔ View full report in Codecov by Sentry. |
chenkasirer
reviewed
Oct 24, 2024
Comment on lines
+131
to
+149
| mesh = Mesh.from_meshgrid(10, 10) | ||
| before = Mesh() | ||
| for vertex in mesh.vertices(): | ||
| attr = mesh.vertex_attributes(vertex) | ||
| before.add_vertex(key=vertex, attr_dict=attr) | ||
| for face in mesh.faces(): | ||
| attr = mesh.face_attributes(face) | ||
| before.add_face(vertices=mesh.face_vertices(face), fkey=face, attr_dict=attr) | ||
| after = compas.json_loads(compas.json_dumps(before)) # type: Mesh | ||
|
|
||
| assert before.__dtype__ == after.__dtype__ | ||
| assert all(before.has_vertex(vertex) for vertex in after.vertices()) | ||
| assert all(after.has_vertex(vertex) for vertex in before.vertices()) | ||
| assert all(before.has_face(face) for face in after.faces()) | ||
| assert all(after.has_face(face) for face in before.faces()) | ||
| assert all(before.has_edge(edge) for edge in after.edges()) | ||
| assert all(after.has_edge(edge) for edge in before.edges()) | ||
| assert all(before.face_vertices(a) == after.face_vertices(b) for a, b in zip(before.faces(), after.faces())) | ||
| assert before.guid == after.guid |
There was a problem hiding this comment.
where are AttributeViews added here to the mesh?
There was a problem hiding this comment.
whenever you ask for attributes of en element but don't specify which ones, you automatically get a view of the entire dict
chenkasirer
reviewed
Oct 24, 2024
Co-authored-by: Chen Kasirer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.