Patents api

[jeorryb]

I wanted to see if I was on the right track. I removed explicit paramaters and have them defined in a config file. I also created a class for Patent. I also removed the function that is performing argument parsing since that is being handled elsewhere. Thank you!

[Mierdin]

Two things:

1. What are your plans for Adding bindings for the "Patents" API #13?
2. Is this a WIP PR or is it ready for a review?

[jeorryb]

I was think of output to a file if an argument is present in the Params. I'll work on adding that tomorrow as well as unit tests for the API. Can we start adding parameters in the sub-argument section of commands.py for our relevant API?

[jeorryb]

Still WIP, wanted some feedback if I was headed in the right direction.

[Mierdin]

At this point I would just focus on writing a class/functions for the Patents API only. Don't worry about the CLI or commands. In terms of testing this functionality, that can/should be done by a unit test anyways, so you might want to include that. Again, think of this as just a part of a library. Ignore for now the fact that this will be used by a CLI, because the reality is it may not always. We want to design this part of the library to be accessible to both the CLI package we'll create later, as well as some other 3rd party Python code.

EDIT: Accidentally hit the close button....reopening

[Mierdin]

@jeorryb What's the state of this PR? Ready for me to take a peek? Also, any relation to #13?

[jeorryb]

Almost done with the unit tests. Slow going right now since I'm wrapping my head around mock and unittest. Hopefully I'll be able to submit the PR by end of day.

[Mierdin]

@jeorryb Great news! Don't hesitate to ask for help, I remember how difficult mock was when I first learned it.

[jeorryb]

Not sure if you saw the slack channel, but I'm having difficulty import packages outside of the "tests" directory. I've verified the existence of __init__.py at the various directories. When I'm directly in the pybluedot/tests directory I'm able to import base.py. When I'm in the pybluedot/tests/unit directory I can't import any package outside of that directory. Examples would be "from pybluedot.tests import base" or "from tests import base". Any ideas?

…

On Mon, Dec 19, 2016 at 1:35 PM, Matt Oswalt ***@***.***> wrote: @jeorryb <https://github.com/jeorryb> Great news! Don't hesitate to ask for help, I remember how difficult mock was when I first learned it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQW19WOahrckFCM3s6hRQPA89765ZVGeks5rJs52gaJpZM4LIRn3> .

-- Jeorry Balasabas [email protected]