Merge pull request #16 from comet-ml/s3-force-delete

Enable force_destroy option for s3 bucket
comet-ml · Jan 12, 2024 · 779cde7 · 779cde7
2 parents 3c7654f + 10c3e74
commit 779cde7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/main.tf b/main.tf
@@ -125,4 +125,5 @@ module "comet_s3" {
   environment = var.environment
 
   comet_s3_bucket = var.s3_bucket_name
+  s3_force_destroy = var.s3_force_destroy
 }
diff --git a/modules/comet_s3/main.tf b/modules/comet_s3/main.tf
@@ -8,6 +8,8 @@ locals {
 resource "aws_s3_bucket" "comet_s3_bucket" {
   bucket = var.comet_s3_bucket
 
+  force_destroy = var.s3_force_destroy
+
   tags = merge(local.tags, {
     Name = var.comet_s3_bucket
   })

diff --git a/modules/comet_s3/variables.tf b/modules/comet_s3/variables.tf
@@ -6,4 +6,9 @@ variable "environment" {
 variable "comet_s3_bucket" {
   description = "Name of S3 bucket"
   type        = string
+}
+
+variable "s3_force_destroy" {
+  description = "Option to enable force delete of S3 bucket"
+  type        = bool
 }
diff --git a/variables.tf b/variables.tf
@@ -334,6 +334,12 @@ variable "s3_bucket_name" {
   type        = string
 }
 
+variable "s3_force_destroy" {
+  description = "Option to enable force delete of S3 bucket"
+  type        = bool
+  default     = false
+}
+
 #### comet_vpc ####
 variable "single_nat_gateway" {
   description = "Controls whether single NAT gateway used for all public subnets"