[OPIK-611] support gemini models in playground #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Jan 7, 2025
apps/opik-backend/src/test/java/com/comet/opik/domain/llmproviders/LlmProviderFactoryTest.java
Outdated
Show resolved
Hide resolved
idoberko2
force-pushed
the
ido/opik-611-support-gemini-models
branch
from
26842dd to
7a42987
Compare
andrescrz
previously approved these changes
Jan 8, 2025
apps/opik-backend/src/main/java/com/comet/opik/api/LlmProvider.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/ChunkedResponseHandler.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/ChunkedResponseHandler.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/ChunkedResponseHandler.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/ChunkedResponseHandler.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Jan 8, 2025
idoberko2
force-pushed
the
ido/opik-611-support-gemini-models
branch
from
b7b5979 to
82d7a2b
Compare
thiagohora
reviewed
Jan 13, 2025
...pik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderAnthropicMapper.java
Outdated
Show resolved
Hide resolved
...pik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderAnthropicMapper.java
Show resolved
Hide resolved
...pik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderClientGenerator.java
Outdated
Show resolved
Hide resolved
...pik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderClientGenerator.java
Outdated
Show resolved
Hide resolved
...-backend/src/test/java/com/comet/opik/domain/llmproviders/LlmProviderClientsMappersTest.java
Outdated
Show resolved
Hide resolved
andrescrz
previously approved these changes
Jan 13, 2025
| This information is taken from: https://ai.google.dev/gemini-api/docs/models/gemini | ||
| */ | ||
| @RequiredArgsConstructor | ||
| public enum GeminiModelName { |
There was a problem hiding this comment.
Make sure these values are as complete as possible and also aligned with the FrontEnd choices.
There was a problem hiding this comment.
I double checked against the gemini documentation (link in comments). Will update the FE ticket accordingly.
idoberko2
force-pushed
the
ido/opik-611-support-gemini-models
branch
from
13892f3 to
396c28c
Compare
andrescrz
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
OPIK-611
Testing
Covered new logic with tests