[OPIK-757] Add support for comments part2 #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Jan 24, 2025
apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/TracesResource.java
Show resolved
Hide resolved
thiagohora
reviewed
Jan 24, 2025
thiagohora
reviewed
Jan 24, 2025
thiagohora
reviewed
Jan 24, 2025
thiagohora
reviewed
Jan 24, 2025
| .bind("entity_type", entityType.getType()); | ||
|
|
||
| return makeMonoContextAware(bindWorkspaceIdToMono(statement)) | ||
| .then(); |
There was a problem hiding this comment.
It is better to return the affected rows so the client can decide whether to do something about it or not
There was a problem hiding this comment.
I will update in the next PR, good point. Yet in most DAO's in project now we return Void.
There was a problem hiding this comment.
It makes the function more reusable.
thiagohora
reviewed
Jan 24, 2025
| import static com.comet.opik.utils.ValidationUtils.CLICKHOUSE_FIXED_STRING_UUID_FIELD_NULL_VALUE; | ||
|
|
||
| @UtilityClass | ||
| public class CommentResultMapper { |
There was a problem hiding this comment.
Suggested change
| public class CommentResultMapper { | |
| class CommentResultMapper { |
thiagohora
reviewed
Jan 24, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/CommentResultMapper.java
Show resolved
Hide resolved
thiagohora
reviewed
Jan 24, 2025
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/TracesResourceTest.java
Show resolved
Hide resolved
thiagohora
approved these changes
Jan 24, 2025
BorisTkachenko
deleted the
OPIK-757-add-support-for-comments-existing-endpoints-part2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add support for comments
Testing
Integration tests