Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-766] run code snippet button #1088

Merged
merged 8 commits into from
Jan 24, 2025
Merged

[OPIK-766] run code snippet button #1088

merged 8 commits into from
Jan 24, 2025

Conversation

awkoy
Copy link
Contributor

@awkoy awkoy commented Jan 20, 2025

Details

  • run snippet code button
image image

Issues

Resolves #

Testing

Documentation

@awkoy awkoy requested a review from a team as a code owner January 20, 2025 16:12
aadereiko
aadereiko requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should communicate the info about env variables
image
  1. Autoscroll behaviour scrolls down so I can't see logs.
image

apps/opik-frontend/src/components/shared/CodeExecutor/CodeExecutor.tsx Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/shared/CodeExecutor/CodeExecutor.tsx Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/shared/CodeExecutor/CodeExecutor.tsx Outdated Show resolved Hide resolved
...rontend/src/components/pages-shared/onboarding/FrameworkIntegrations/IntegrationTemplate.tsx Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/shared/CodeExecutor/useRunCodeSnippet.ts Outdated Show resolved Hide resolved
apps/opik-frontend/.env.comet Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/shared/CodeExecutor/useRunCodeSnippet.ts Outdated Show resolved Hide resolved
...tend/src/components/pages-shared/onboarding/FrameworkIntegrations/quickstart-integrations.ts Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/shared/CodeExecutor/useRunCodeSnippet.ts Outdated Show resolved Hide resolved
@awkoy awkoy requested a review from aadereiko January 23, 2025 11:53
aadereiko
aadereiko requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work in general!
Some small relocations of files are needed just to follow the structure of the project. Remove the env variable to hide the feature for the time being and solve the conflicts

apps/opik-frontend/src/components/pages-shared/onboarding/CodeExecutor/CodeExecutor.tsx Show resolved Hide resolved
apps/opik-frontend/src/components/pages-shared/onboarding/CodeExecutor/useRunCodeSnippet.ts Outdated Show resolved Hide resolved
apps/opik-frontend/src/components/pages-shared/onboarding/CodeExecutor/useRunCodeSnippet.ts Outdated Show resolved Hide resolved
apps/opik-frontend/.env.comet Outdated Show resolved Hide resolved
...rc/components/pages-shared/onboarding/FrameworkIntegrations/integration-scripts/fake-logs.ts Outdated Show resolved Hide resolved
...tend/src/components/pages-shared/onboarding/FrameworkIntegrations/quickstart-integrations.ts Show resolved Hide resolved
@awkoy awkoy requested a review from aadereiko January 24, 2025 10:25
aadereiko
aadereiko approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@awkoy awkoy merged commit 289fcb8 into main Jan 24, 2025
1 check passed
@awkoy awkoy deleted the awkoy/OPIK-766-run-snippet-button branch January 24, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadereiko aadereiko aadereiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awkoy @aadereiko