[OPIK-720] Manually set span cost #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Jan 9, 2025
thiagohora
reviewed
Jan 10, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
thiagohora
reviewed
Jan 10, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
BorisTkachenko
force-pushed
the
boryst/OPIK-720-add-the-possibility-to-manually-sets-the-cost-of-individual-spans
branch
from
20a738c to
50028b1
Compare
BorisTkachenko
force-pushed
the
boryst/OPIK-720-add-the-possibility-to-manually-sets-the-cost-of-individual-spans
branch
from
8deeb69 to
1b455fe
Compare
thiagohora
reviewed
Jan 13, 2025
BorisTkachenko
force-pushed
the
boryst/OPIK-720-add-the-possibility-to-manually-sets-the-cost-of-individual-spans
branch
from
33d23dc to
c7dd542
Compare
added |
andrescrz
reviewed
Jan 13, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
Outdated
Show resolved
Hide resolved
andrescrz
previously approved these changes
Jan 13, 2025
BorisTkachenko
force-pushed
the
boryst/OPIK-720-add-the-possibility-to-manually-sets-the-cost-of-individual-spans
branch
from
f5aad50 to
aef6628
Compare
andrescrz
approved these changes
Jan 13, 2025
BorisTkachenko
deleted the
boryst/OPIK-720-add-the-possibility-to-manually-sets-the-cost-of-individual-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Manually set span cost
Testing
Covered with integration tests