[OPIK-735] Online Scoring: null projectId error when creating a rule #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
previously approved these changes
Jan 9, 2025
andrescrz
previously approved these changes
Jan 10, 2025
| @NotNull UUID projectId; | ||
| @JsonView({View.Public.class}) | ||
| @Schema(accessMode = Schema.AccessMode.READ_ONLY) | ||
| UUID projectId; |
There was a problem hiding this comment.
This class is marked with @Data so it has setters and getters. However, all these fields should be marked as private.
There was a problem hiding this comment.
I just noticed that this is meant to be extendable, so ok to have default visibility or protected for extension outside the package. You can still opt to narrow down visibility to private if you prefer.
thiagohora
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Using the endpoint, if the projectId is null in the payload, but ok in the path parameter, the rule creationg is aborted due to a 'projectId cant be null'.
During the triage I can see the service was using the projectId from the payload (which is optional and service should not use), while the correct would be use from the path param.
Issues
Resolves #
Testing
Documentation