Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation of factory() #89

Merged
merged 4 commits into from
Aug 18, 2024

Conversation

hexagonrecursion
Copy link
Contributor

  1. The link to cbot\file was a red herring - factory() only accepts strings, not file handles.
  2. It took me a lot of effort to figure out how to make factory() accept a file name. Who could have guessed that I have to prefix it with program/? Documenting it here for future players.
  3. Fixes Moon Mission 1, and possibly others colobot#1522 by adding an example of how to correctly pass a public function to factory()

@AndreiCherniaev
Copy link
Contributor

Good job!

Please add Russian also!
En. "Program that will be run on the bot after factory finishes the construction. This can be either a \l;public\u cbot\public; \l;function\u cbot\function;, a filename or raw code."
Ru. "Программа, которая будет запускаться на боте после завершения строительства завода. Это может быть \l;public\u cbot\public; \l;function\u cbot\function;, имя файла или фрагмент кода."

En. "Save this as say-foo.cbot. Note: make sure to check the "Public" checkbox when saving - this will cause say-foo.cbot to be inside the program/ folder."
Ru. "Сохраните это как say-foo.cbot. Примечание. При сохранении обязательно установите флажок «Public» — чтобы say-foo.cbot оказался внутри папки program/."

Please add others languages using auto translation!

Update the translations of the documentation of the factory() function.

The Russian translation is based on the suggestions made by
@AndreiCherniaev with my own corrections and additions.

Czech, German, French, Polish and Brazilian Portuguese translations are
partially based on the work by previous translators and partially are a
machine tranlation.
@hexagonrecursion
Copy link
Contributor Author

@AndreiCherniaev done.

@hexagonrecursion
Copy link
Contributor Author

Ping?

@hexagonrecursion
Copy link
Contributor Author

@AndreiCherniaev What? Are the translations wrong?

Copy link
Contributor

@AndreiCherniaev AndreiCherniaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@tomangelo2 tomangelo2 merged commit 3d9a0c4 into colobot:dev Aug 18, 2024
2 checks passed
@hexagonrecursion hexagonrecursion deleted the factory-example branch August 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants