fix: arg type for std::ceil and typo in glomap::EstimateRelativePoses #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this bug. LGTM. |
ahojnnes
approved these changes
Sep 9, 2024
ahojnnes
reviewed
Sep 9, 2024
| @@ -20,14 +20,15 @@ void EstimateRelativePoses(ViewGraph& view_graph, | |||
|
|
|||
| const int64_t num_image_pairs = valid_pair_ids.size(); | |||
| const int64_t kNumChunks = 10; | |||
| const int64_t inverval = std::ceil(num_image_pairs / kNumChunks); | |||
| const int64_t interval = | |||
| std::ceil(static_cast<double>(num_image_pairs) / kNumChunks); | |||
There was a problem hiding this comment.
Suggested change
| std::ceil(static_cast<double>(num_image_pairs) / kNumChunks); | |
| std::min(num_image_pairs / kNumChunks, 1); |
There was a problem hiding this comment.
nit: this would be a safer alternative that handles the full range of int64 numbers while double may not hold the full range of int64 numbers. This is unrealistic though, because this for loop would probably run for a very very long time.
There was a problem hiding this comment.
Thanks so much! I really did not take this problem into account. But as you say, I think there won't be anyone processing so many pictures. 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this bug when reconstructing 4 images.
std::ceil(num_image_pairs / kNumChunks)equals to zero at here for int64(4/10) equals zero, and the relative pose estimation actually failed here.