Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ruff and minor fixes #1390

Merged
merged 1 commit into from
Aug 2, 2024
Merged

bump ruff and minor fixes #1390

merged 1 commit into from
Aug 2, 2024

Conversation

collerek
Copy link
Owner

@collerek collerek commented Aug 2, 2024

No description provided.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (81bb434) to head (507da12).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       206           
  Lines        14940     14940           
=========================================
  Hits         14940     14940           
Files Coverage Δ
ormar/models/helpers/models.py 100.00% <ø> (ø)
ormar/models/helpers/relations.py 100.00% <100.00%> (ø)
ormar/models/helpers/validation.py 100.00% <100.00%> (ø)
ormar/models/metaclass.py 100.00% <100.00%> (ø)
ormar/queryset/actions/order_action.py 100.00% <100.00%> (ø)
ormar/relations/querysetproxy.py 100.00% <100.00%> (ø)

Copy link

codspeed-hq bot commented Aug 2, 2024

CodSpeed Performance Report

Merging #1390 will degrade performances by 23.44%

Comparing bump-ruff-and-lint-fixes (507da12) with master (81bb434)

Summary

⚡ 4 improvements
❌ 1 (👁 1) regressions
✅ 79 untouched benchmarks

Benchmarks breakdown

Benchmark master bump-ruff-and-lint-fixes Change
test_avg[1000] 4.3 ms 3.7 ms +15.91%
test_max[1000] 4.4 ms 3.3 ms +32.43%
test_max[250] 3.6 ms 2.9 ms +23.22%
test_sum[250] 3.6 ms 2.8 ms +27.93%
👁 test_first[1000] 3.1 ms 4 ms -23.44%

@collerek collerek merged commit 1cd9204 into master Aug 2, 2024
20 checks passed
@collerek collerek deleted the bump-ruff-and-lint-fixes branch August 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant