Fix warnings (#282)

* Add base64 to gemspec for Ruby 3.4.0 * Fix not to raise expectations to stop warning
coinbase · Jan 16, 2024 · 3e0dae7 · 3e0dae7
1 parent 95d62d2
commit 3e0dae7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/spec/unit/lib/temporal/activity_spec.rb b/spec/unit/lib/temporal/activity_spec.rb
@@ -64,7 +64,7 @@ def execute(a, b:, c:)
       it 'does not raise an ArgumentError' do
         expect {
           described_class.execute_in_context(context, input)
-        }.not_to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1; required keywords: b, c)')
+        }.not_to raise_error
       end
 
       it 'returns #execute result' do

diff --git a/spec/unit/lib/temporal/workflow_spec.rb b/spec/unit/lib/temporal/workflow_spec.rb
@@ -65,7 +65,7 @@ def execute(a, b:, c:)
       it 'does not raise an ArgumentError' do
         expect {
           described_class.execute_in_context(ctx, input)
-        }.not_to raise_error(ArgumentError, 'wrong number of arguments (given 2, expected 1; required keywords: b, c)')
+        }.not_to raise_error
       end
     end
   end

diff --git a/temporal.gemspec b/temporal.gemspec
@@ -14,6 +14,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.files         = Dir["{lib,rbi}/**/*.*"] + %w(temporal.gemspec Gemfile LICENSE README.md)
 
+  spec.add_dependency 'base64'
   spec.add_dependency 'grpc'
   spec.add_dependency 'oj'