fix: formatDecimals precision
#912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cpcramer
reviewed
Jul 26, 2024
cpcramer
reviewed
Jul 26, 2024
| if (inputInDecimals) { | ||
| return (Number(amount) / 10 ** decimals).toString(); | ||
| // If input is already in decimals, convert to readable amount |
There was a problem hiding this comment.
What do we mean by "readable" amount?
cpcramer
approved these changes
Jul 26, 2024
|
@0xAlec could you rebase from main when you have a minute? With all our tests in order, it'll help our CI pass more easily. |
Zizzamia
reviewed
Jul 28, 2024
Zizzamia
reviewed
Jul 28, 2024
Zizzamia
reviewed
Jul 28, 2024
src/swap/utils/formatDecimals.ts
Outdated
| } | ||
| if (!/^(?:0|[1-9]\d*)(?:\.\d+)?$/.test(amount)) { | ||
| throw new Error( | ||
| 'Invalid input: amount must be a non-negative number string', |
There was a problem hiding this comment.
Love the care for the messages.
Zizzamia
reviewed
Jul 28, 2024
Zizzamia
reviewed
Jul 28, 2024
0xAlec
force-pushed
the
alec/precision-fix
branch
from
19f7bdb to
5214fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
amountfrom a string to a javascript number (max 64 bits), which would lose precision for some ERC-20 denominationsBigIntimplementationNotes to reviewers
How has it been tested?
improved test coverage compared to
mainunit tested and tested locally