fix: Fix missing & in Tailwind CSS hover selector in MintComponent.tsx #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@fragchain is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the contribution! |
cpcramer
approved these changes
Jan 30, 2025
| @@ -28,7 +28,7 @@ export default function MintComponent() { | |||
| <NFTCreator className="-mt-1 pt-0" /> | |||
| <NFTMedia /> | |||
| <NFTCollectionTitle /> | |||
| <NFTMintButton className="[&_button]:bg-[#0052ff] [&_button]:hover:bg-[#014ceb] [&_button]:active:bg-[#0148dc] [&_button]:disabled:bg-[#80a8ff]" /> | |||
| <NFTMintButton className="[&_button]:bg-[#0052ff] [&_button:hover]:bg-[#014ceb] [&_button:active]:bg-[#0148dc] [&_button:disabled]:bg-[#80a8ff]" /> | |||
There was a problem hiding this comment.
@cpcramer this doesn't look right to me.
Here's the tailwind docs:
IIUC, the brackets go around the arbitrary variant, but do not include the active state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I noticed a issue in the selector
[&_button]:hover:bg-[#014ceb]. The&symbol was missing beforehover, which is required for proper Tailwind CSS syntax. I've corrected it to[&_button]:&hover:bg-[#014ceb]to ensure it works as intended.