Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Native Send Component #1874
base: main
Are you sure you want to change the base?
feat: Native Send Component #1874
Changes from 50 commits
a86df54
9847c09
318e32a
ff7d2fa
9afd32d
96f02d7
53433ae
7254218
e9254e2
8f30262
b921ac5
91a38a7
3d86e6e
51fd103
f43e395
08757f8
33ba23d
210adc5
020bbf7
8fd2959
e0e628b
779c941
9eb6db5
a44d528
ff8e814
25b8a55
c534c15
55f53ff
8f0a51f
35bf65d
9df538d
1ff95e5
6982ae7
2279e9b
e5cafbd
35b25ca
eb50673
250b5ee
4498479
67195c7
8b49f1d
aafd0b4
8cfd20f
faaf63b
830a6c9
2c24140
13e6444
4e2921e
7ef5f64
cdc00d7
1236114
6d9c479
f2ab55b
d782eb0
767ce16
3a33745
ba7f51a
6bee52c
4245695
df2930b
80f180a
255cfb4
f0beaef
90eacf3
5d031a4
ddf6abf
9816bcb
4281d2e
c76fe05
1f58995
58275a6
b13ecd6
5693495
1ced463
7418419
9262f14
c444463
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
<span >
here? Probably should be a button if it's clickableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't have a button within a button, and sometimes the whole container is a button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what the need for
trim()
is here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tokens have whitespace at the front / end for style /s. we don't want that