[chore] Update Coinbase Constructor Args Default #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
reviewed
Jun 5, 2024
John-peterson-coinbase
force-pushed
the
chore-update-coinbase-constructor-args
branch
from
ccdd24b to
06d09bf
Compare
John-peterson-coinbase
force-pushed
the
chore-update-coinbase-constructor-args
branch
from
06d09bf to
dd032af
Compare
erdimaden
reviewed
Jun 5, 2024
| @@ -121,7 +121,7 @@ export class Coinbase { | |||
| useServerSigner = false, | |||
| debugging = false, | |||
| basePath = BASE_PATH, | |||
| }: CoinbaseConfigureFromJsonOptions): Coinbase { | |||
| }: CoinbaseConfigureFromJsonOptions = {}): Coinbase { | |||
There was a problem hiding this comment.
since we already changed typing, we don't need to have {}
There was a problem hiding this comment.
this is for the configure from json options where passing undefined is valid
erdimaden
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact